Jonas Ådahl [Mon, 23 Mar 2026 12:26:51 +0000 (13:26 +0100)]
st/texture-cache: Add missing error reporting
st_texture_cache_load_file_sync_to_cogl_texture() loads a file into a
texture, but if pixbuf_to_st_content_image() failed, it'd return that it
failed, but wouldn't set an error, which would cause a null pointer
dereference when attempting to log the error message in the caller. Fix
this by setting an error on all error paths.
Sebastian Keller [Thu, 26 Mar 2026 18:29:44 +0000 (19:29 +0100)]
keyboard: Ensure minimum height of the OSK always fits on screen
At very low resolutions, 1/3 of the screen height might not be enough
for the minimum height of the OSK, causing some keys to get pushed out
of the screen. This now ensures the height is always at least the
minimum height, but only up to 1/2 of the screen to avoid situations
where the OSK would cover the whole screen preventing any other
interaction.
Peter Hutterer [Tue, 24 Mar 2026 00:37:36 +0000 (10:37 +1000)]
tools/toolbox: Ignore missing config files
The config file is created by our own create-toolbox.sh script which
sets the DEFAULT_TOOLBOX name. But for toolboxes created directly
that file doesn't exist, so let's skip over that (and thus require
the toolbox name to be given on the commandline or via an env var).
Sebastian Keller [Tue, 17 Mar 2026 03:21:09 +0000 (04:21 +0100)]
quickSettings: Consider menu width when calculating its preferred height
Previously the width of a menu was ignored when calculating its
preferred height. This was leading to line wrapped text never being
wrapped in these calculations and thus the menu being assumed to be
shorter than it actually ends up when allocated with line wrapping.
Sebastian Keller [Tue, 17 Mar 2026 01:51:44 +0000 (02:51 +0100)]
quickSettings: Adjust menu width using contraints instead of CSS
The width of the overlay actor for quick settings menus was as wide as
the whole box pointer and the menus placed inside the overlay actor were
then adjusted with CSS margins to have the same width and spacing as the
other elements.
This meant that in `QuickSettingsLayout` the width of the overlay actor
would have to be dependent on the size of a parent actor rather than the
associated container. In the next commit we are however going to need to
use the correct width, so this commit changes the width of the overlay
actor to be the same as other actors in the grid.
This also avoids the need to use CSS to adjust the width and horizontal
placement.
Sebastian Keller [Sat, 21 Mar 2026 22:38:16 +0000 (23:38 +0100)]
st/viewport: Include padding in paint volume origin calculation
In the presence of adjustments, the paint volume had its size adjusted
for the padding of the viewport, but not its origin. This was leading to
scrollable viewports with a padding having their paint volumes shifted
too far to the left causing some artifacts on the right when scrolling.
One place where this could be observed was the window list in looking
glass.
This now correctly adjusts the origin, simplifies the code and moves it
into the only condition where the adjustment is needed.
DaPigGuy [Fri, 20 Mar 2026 01:48:13 +0000 (18:48 -0700)]
shell: Fix overcounting of misc. symbols for password strength
There was previously a branch for lowercase symbols that was removed.
Lowercase symbols should not count as miscellaneous symbols, which
increase the password strength.
Maksim Mazko [Mon, 2 Mar 2026 17:44:56 +0000 (20:44 +0300)]
status/keyboard: Preserve MRU order while IBus is disabled
In password fields, IBus sources are temporarily disabled and a backup
of the MRU list is created. If the user switches layouts in that state,
the active MRU list is updated, but the backup is not.
When IBus is enabled again, the stale backup is restored and the order
the user just selected is lost. Sync the backup on interactive source
switches while IBus is disabled, so the MRU order stays consistent.
Florian Müllner [Thu, 12 Mar 2026 10:32:40 +0000 (11:32 +0100)]
boxpointer: Properly update arrow side when requested
Boxpointer tracks both the "user arrow side", which is the side
that was explicitly specified, and the "arrow side", which is the
actual side that may have been flipped due to space constraints.
However the former currently always keeps tracking the side that
was specified at construction time, even if it is explicitly
changed with `updateArrowSide()`.
That means that on allocation, the arrow side is reverted to its
original value again, unless the flip calculation happens to turn
it into the intended value.
This is unexpected, so update both current and intended arrow side
when updating the arrow side.
Florian Müllner [Fri, 13 Mar 2026 11:47:48 +0000 (12:47 +0100)]
boxpointer: Queue relayout after updating arrow side
We currently queue a repaint after setting a new arrow side, but
that seems insufficient - moving the arrow from top/bottom to the
left/right for example may very well affect the layout, plus the
arrow may need flipping due to size constraints (which happens
on allocation).
Sebastian Keller [Fri, 13 Mar 2026 00:27:29 +0000 (01:27 +0100)]
systemActions: Fix initial visibility of logout action
When `_updateLogout()` is called on login, the AccountsService user
might not have been loaded yet. This would have resulted in all values
being null/false, including `local_account`. Since `!localAccount` is
one of the cases where the action is available, this would have wrongly
resulted in the item being shown when not intended to be shown. But only
until something triggers another call of `_updateLogout()`, such as
locking/unlocking the session.
Daniel Rusek [Thu, 12 Mar 2026 10:34:26 +0000 (10:34 +0000)]
data: Re-add old Passwords and Keys desktop name
Seahorse desktop file name was changed in upstream, but the new release
was delayed. This caused Seahorse to be outside the Utilities folder in
newer distributions, which is not correct.
The new Seahorse version should be out soon, so reverting the new name
is not a good idea. Instead, the old name should be added back.
Florian Müllner [Wed, 11 Mar 2026 21:37:20 +0000 (22:37 +0100)]
main: Also respect --force-animations flag in remote sessions
When commit 33d3a6564 added support for the --force-animations flag,
it explicitly excluded remote sessions.
There has been some interest in enabling the flag for remote sessions
as well recently, and as nobody seems to remember why they were
excluded, do just that.
When an app folder is open and its panel is shown, there are
three main elements: the folder name, the list of apps, and the
Edit togglebutton. By default, the user can use TAB to jump
between the app icons and the Edit togglebutton, but when the
togglebutton is checked, the folder name becomes editable and
the focus jumps to it.
Unfortunately, if the user goes out of the editable name with
TAB, the focus only cycles between the Edit togglebutton and
the app icons, never landing over the editable folder name (which
remains editable until the Edit togglebutton is unchecked).
This patch fixed this, making the editable folder name focusable
when using TAB, as expected, when the Edit togglebutton is
checked.
appDisplay: Fix accessibility for application folders
Currently, application folders have a `checkbutton` role, which
is confusing for the user because it's not something that
changes its checked status, but a button that opens the contents
of the folder. Also, the only indication that this is a folder
and not a "normal" application is that role, which means that an
user must know that pushbuttons are applications and checkbuttons
are folders, which is confusing.
This patch fixes this by adding the "expandable" accessible
state to the folder button, thus notifying the user that it is
an element with extra elements inside.
It also adds the folder name and the type as the full container
label when opening a folder, thus ensuring that the user knows
where they are.
Florian Müllner [Thu, 5 Mar 2026 15:22:41 +0000 (16:22 +0100)]
appDisplay: Stop using toggle-mode with folder icons
This is essentially a left-over from the original folder design, dating
all the way back to commit 6e3e2d9 in 2013.
It no longer makes much sense with the current design iteration, where
we pretend that the icon pops out of the grid and becomes the dialog
(i.e. we hide the icon and zoom out the dialog from its position).
messageTray: Avoid notification double destruction after activation
The activation handler of a notification may indirectly have already
destroyed it before `activate()` continues and tries to destroy it.
This happened for example in the `FdoNotificationDaemon` activation
handler when no default actions are specified, which ends up calling
`destroyNonResidentNotifications()`.
Another case where this could happen is the `WindowAttentionHandler`
which activates the window and upon activation of the window destroys
the entire notification source, which also destroys the notification.
Florian Müllner [Thu, 12 Feb 2026 12:50:47 +0000 (13:50 +0100)]
layout: Wait for backgrounds to load, even when interrupted
We no longer get stuck when a background manager is destroyed during
the startup animation, but we now resolve before the new backgrounds
have been loaded.
Address this by keeping the returned promise around until it is fulfilled,
and only resolve it after backgrounds were loaded successfully.
Florian Müllner [Tue, 10 Feb 2026 14:30:46 +0000 (15:30 +0100)]
layout: Reject promise if background loading is interrupted
Currently if a background manager is destroyed while we are waiting
for the background to load, the corresponding promise never resolves.
To prevent this from happening (and the startup animation getting
stuck as a result), guard the loading operation with a cancellable
and reject the promise when it is cancelled.
Adrian Vovk [Fri, 27 Feb 2026 21:21:46 +0000 (16:21 -0500)]
systemActions: Call into gnome-session for suspend
gnome-shell previously talked to logind directly on its own. This,
however, will lead to code duplication: the various inhibitor handling
bugfixes I've made to gnome-session (i.e. handling the new return values
from CanPowerOff/CanReboot/CanSuspend) would have to be copied into
gnome-shell. So instead, this commit just moves the responsibility for
handling suspend into gnome-session.
Adrian Vovk [Tue, 20 Jan 2026 05:04:57 +0000 (00:04 -0500)]
systemActions: Separate CanReboot from CanShutdown
The reboot actions and shutdown actions are independent, and might have
independent availability. It's perfectly valid for a system
administrator to configure a system where one action is available and
the other isn't. This commit separates the availability of these
actions, and allows them to be independently shown/hidden
Adrian Vovk [Fri, 27 Feb 2026 20:58:17 +0000 (15:58 -0500)]
systemActions: Switch to updated CanShutdown() API
There's corresponding changes in gnome-session that report more detail
about the availability of the action. This allows gnome-shell to
appropriately hide the action whenever it is inhibited, and would lead
to a Polkit prompt.
Adrian Vovk [Tue, 20 Jan 2026 05:09:29 +0000 (00:09 -0500)]
endSessionDialog: Immediately return from Open()
There's no need to wait for the dialog to finish fading in before we can
return from Open().
The code, as it was before, would break dialog updates: the dialog was
already open, so the signal would never get emitted, so the method would
never return, and so gnome-session would remain blocked waiting for a
return value that will never come.
st/entry: Fix clutter action leak when unsetting icon
The name of the removed action did not match the added one anymore,
effectively "leaking" an action whenever an icon was shown and hidden.
This was primarily affecting the clear button in the shell search.
Fixes: 0bf49afda ("Replace ClutterClickAction with new ClutterClickGesture")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4095>
Sebastian Keller [Sat, 28 Feb 2026 21:26:15 +0000 (22:26 +0100)]
st/entry: Fix primary/secondary icon leak
_st_entry_set_icon() takes a ref when setting the primary/secondary
icon, but the ref is not removed when unsetting the icon or the entry is
destroyed.
Since clutter_actor_add_child() already adds a ref to the icon, there is
actually no need to manually add another ref. So stop doing that to fix
this leak.
This however also requires that StPasswordEntry takes ownership of its
own icon that it may set or unset multiple times. Since it is initially
floating we need to sink the ref for that.
Sebastian Keller [Fri, 27 Feb 2026 12:22:37 +0000 (13:22 +0100)]
workspaceAnimation: Assign movingWindow before creating window actors
The BaseWorkspaceGroup constructor calls _createWindows(), which uses
_shouldShowWindow() to determine which actors to create for the
animation.
In WorkspaceGroup _shouldShowWindow() this depends on a comparison with
this._movingWindow, which however only gets set after the
BaseWorkspaceGroup constructor has been called.
This was causing the moving window to no longer stick to the screen
when moved between workspaces.
Fixes: 96be47933 ("workspaceAnimation: Split out BaseWorkspaceGroup") Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8992
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4092>
Shivam [Sat, 21 Feb 2026 12:22:35 +0000 (17:52 +0530)]
appDisplay: Refresh folder preview when favorites change
Pinning an app from inside a folder did not refresh the
folder preview. FolderIcon._sync() was only listening
to folder GSettings changes, while pinning updates the
favorites setting instead.
As a result, _sync() was never called and the preview
could show stale icons or remain visible when the folder
became empty.
Fix this by also connecting _sync() to
AppFavorites::changed, ensuring the folder preview
updates correctly when favorites are modified.
Alessandro Bono [Fri, 20 Feb 2026 22:57:14 +0000 (23:57 +0100)]
environment: Use replaceAll()
The replace() function expects two parameters, likely the third one
was ignored. Use replaceAll() to replace all the occurrences, not
just the first one.
Alessandro Bono [Fri, 20 Feb 2026 21:42:03 +0000 (22:42 +0100)]
objectManager: Remove unused function
Introduced with 4b450bab1164b9b1225702238e539201974a68b6, this function
has never been used. Furthermore it is wrong because objectPaths is not
indexed. Just drop it.
Sebastian Keller [Sat, 21 Feb 2026 11:32:26 +0000 (12:32 +0100)]
appDisplay: Consider admin defined folders before creating default ones
The system administrator might have defined some default folders system
wide via dconf default values, so checking for user defined values is
not enough. This restores the condition to also skip creating default
ones if the value is not empty. It still skips the creation of default
folders if the empty value was the result of a user action to allow
users deleting all folders.
Fixes: b0d396c82 ("appDisplay: Only create default folders on the first start") Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/9062
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4087>
search: Do not check for class cancellable state after awaiting
In an async function, after awaiting, the cancelled state for the
class-tracked cancellable may not respect the actual state of the
cancellable that has been used to perform the call.
Cancellable reset API is deprecated for long time and it's quite broken.
In fact if a search provider receives a cancelled event may end up
checking if the cancellable has been cancelled, but this may not be true
anymore after a reset.
Use instead new cancellable instances so that once one is used we can
consider the previous one completed and we can forget about it.
search: Catch async function errors and log them unless cancelled
In case a search function fails, we are not providing clear errors, thus
trace the errors when calling async functions from sync ones and when
catching errors.
Note that at the moment is unlikely to receive any cancelled error here,
since the remote search providers calls handle the error already, but we
still use `logErrorUnlessCancelled` instead of `logError` to be more future
proof or to cover the case in which some extension may throw a cancelled
error.
Jordan Petridis [Mon, 16 Feb 2026 02:06:55 +0000 (04:06 +0200)]
status/volume: Check the stream before accessing it
stream-updated will also get emitted when the stream is unset, and trying
to access it then breaks.
In such case we don't need to update the css class of the indicator as it
will be hidden, and we will get another stream-updated before we show
it again anyway.
main: Call RegisterDisplay once UI has initialized
RegisterDisplay is called to signal that graphics have settled,
which allows GDM to terminate pending greeters and plymouth.
Previously, RegisterSession was used for both recording the login
and terminating greeters. This caused a race condition where the
new user shell was setting up while the greeter was tearing down,
leading to configuration conflicts during the asynchronous handoff.
By splitting into RegisterSession (called early to record login) and
RegisterDisplay (called after graphics settle), the greeter teardown
is delayed until the new session has completed its initial modeset.
Fixes: 32a01330 ("main: Register session with GDM on startup")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4057>
Florian Müllner [Wed, 4 Feb 2026 13:12:25 +0000 (14:12 +0100)]
swipeTracker: Handle invalid position when finding previous point
Commit 8e29babca8adc677 switched to `findLastIndex()` to find
the previous point, which inadvertently changed what value is
returned for invalid input.
Restore the old fallback value and log a stacktrace, so we can
hopefully track down what causes the invalid input.
Sebastian Keller [Wed, 21 Jan 2026 21:54:39 +0000 (22:54 +0100)]
main: Only call gjs_dumpstack() on warnings from main thread
The mozjs code called by gjs_dumpstack() does not appear to be thread
safe and was sometimes resulting in crashes when triggered by error
messages from threads other than the main thread. And even when not
crashing, such a backtrace can only be misleading since only the main
thread is executing JS code.
projects / gnome-shell.git / log